Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgarde to cypress v8.1 #1386

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Upgarde to cypress v8.1 #1386

merged 5 commits into from
Aug 2, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Aug 2, 2021

@asnaith I removed the --browser chrome in ci so that it doesn't pop-up when running it locally. I don't think we saw any difference adding it back then. lmk if you think otherwise.

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Aug 2, 2021
@render
Copy link

render bot commented Aug 2, 2021

@render
Copy link

render bot commented Aug 2, 2021

@render
Copy link

render bot commented Aug 2, 2021

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Aug 2, 2021
@Tbaut Tbaut enabled auto-merge (squash) August 2, 2021 14:05
@Tbaut Tbaut merged commit 5553caf into dev Aug 2, 2021
@Tbaut Tbaut deleted the mnt/ugrade-cypress branch August 2, 2021 14:10
@asnaith
Copy link
Member

asnaith commented Aug 3, 2021

@Tbaut Without the chrome flag the tests will get executed in electron which most (maybe all) our users don't use. I think it's better to force the tests to run in chrome.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Aug 3, 2021

The thing is electron is based on chromium, just like chrome and I thought if it's the default it's it's better suited to run headless in the CI. But I actually found what I wanted, my problem was that chrome was popping up, but we can run it headless, so I'll add it back with that.

edit: #1402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants