-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgarde to cypress v8.1 #1386
Upgarde to cypress v8.1 #1386
Conversation
Your Render PR Server URL is https://storage-ui-stage-pr-1386.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c43u8dpg7hp3ob1bmscg. |
Your Render PR Server URL is https://gaming-ui-stage-pr-1386.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c43u8e1g7hp3ob1bmsv0. |
Your Render PR Server URL is https://files-ui-stage-pr-1386.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c43u8ehg7hp3ob1bmtig. |
@Tbaut Without the chrome flag the tests will get executed in electron which most (maybe all) our users don't use. I think it's better to force the tests to run in chrome. |
The thing is electron is based on chromium, just like chrome and I thought if it's the default it's it's better suited to run headless in the CI. But I actually found what I wanted, my problem was that chrome was popping up, but we can run it headless, so I'll add it back with that. edit: #1402 |
@asnaith I removed the
--browser chrome
in ci so that it doesn't pop-up when running it locally. I don't think we saw any difference adding it back then. lmk if you think otherwise.