-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for new shared folder #1390
Conversation
Your Render PR Server URL is https://storage-ui-stage-pr-1390.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c444gac7o9qecmt5eemg. |
Your Render PR Server URL is https://gaming-ui-stage-pr-1390.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c444gas7o9qecmt5ef30. |
Your Render PR Server URL is https://files-ui-stage-pr-1390.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c444gb47o9qecmt5efcg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
We just need to add the validator to create shared folder during share file!
Ah thanks I thought I had that in. I'll check it out. |
Should be good now @tanmoyAtb |
Looking good but I noticed these changes also stop the user from having a legitimate space in the name, for example "My Share" is no longer possible. 🟩 User cannot create a folder with name being white space only |
Nice catch! will fix that. |
ok should be good to go now |
This PR seems to be breaking the
|
packages/files-ui/src/Components/Modules/FileBrowsers/CopyToSharedFolderModal.tsx
Outdated
Show resolved
Hide resolved
…ub.com:ChainSafe/files-ui into fix/tbaut-validate-shared-folder-creation-1293
…aredFolderModal.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff :)
I'll stop there, thanks a lot for the thought review, this was really needed, and I'm super glad the tests caught a bug, nice catch @FSM1 ! I think this will conflict with Tanmoy's PR, I'll merge his before |
…ub.com:ChainSafe/files-ui into fix/tbaut-validate-shared-folder-creation-1293
closes #1293