Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding buckets user logic #1394

Merged
merged 8 commits into from
Aug 3, 2021
Merged

Adding buckets user logic #1394

merged 8 commits into from
Aug 3, 2021

Conversation

RyRy79261
Copy link
Contributor

@RyRy79261 RyRy79261 commented Aug 3, 2021 •
edited by Tbaut
Loading

closes #1266
closes #1280

@RyRy79261 RyRy79261 self-assigned this Aug 3, 2021
@render
Copy link

render bot commented Aug 3, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1394.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c44jjtht9ds8sa1cj68g.

@render
Copy link

render bot commented Aug 3, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1394.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c44jjtpt9ds8sa1cj6l0.

@render
Copy link

render bot commented Aug 3, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1394.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c44jju9t9ds8sa1cj6ug.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Aug 3, 2021
@RyRy79261 RyRy79261 marked this pull request as ready for review August 3, 2021 13:42
@RyRy79261 RyRy79261 added the Status: Review Needed 👀 Added to PRs when they need more review label Aug 3, 2021
Tbaut
Tbaut reviewed Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dope. One thing that is missing is getting those Users in the CreateOrEditSharedFolderModal.tsx or more precisely in the useLookupSharedFolderUser hook.

nit: can we have the 0x from Ethereum addresses with a small X, the big is unusual (I guess this is something for the api? worst case with toLowerCase it here)

packages/files-ui/src/Contexts/FilesContext.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/views/FileSystemItem/SharedFolderRow.tsx Outdated Show resolved Hide resolved
RyRy79261 and others added 2 commits August 3, 2021 16:05
@RyRy79261 @Tbaut
Update packages/files-ui/src/Contexts/FilesContext.tsx
46542fa 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@RyRy79261 @Tbaut
Update packages/files-ui/src/Components/Modules/FileBrowsers/views/Fi…
ee65f76 
…leSystemItem/SharedFolderRow.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Tbaut
Tbaut reviewed Aug 3, 2021
View reviewed changes
packages/files-ui/src/Contexts/FilesContext.tsx
return {
...b,
encryptionKey: await getKeyForBucket(b) || "",
permission: getPermissionForBucket(b)
permission: getPermissionForBucket(b),
owners: userData.owners || [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw the type tells this can't be null, but I see it is. I added it to an issue I opened for a similar problem https://github.com/ChainSafe/files-api/issues/1383#issuecomment-891879713

@RyRy79261 RyRy79261 requested a review from Tbaut August 3, 2021 16:04
@tanmoyAtb
Copy link
Contributor

This is dope. One thing that is missing is getting those Users in the CreateOrEditSharedFolderModal.tsx or more precisely in the useLookupSharedFolderUser hook.

nit: can we have the 0x from Ethereum addresses with a small X, the big is unusual (I guess this is something for the api? worst case with toLowerCase it here)

I think we won't need the API call in CreateOrEditSharedFolder, since there we already have users' info in the bucket. and lookup already returns usernames. we have an issue for it -> #1280

tanmoyAtb
tanmoyAtb approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!
looks like this PR also closes #1280

Tbaut
Tbaut approved these changes Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's dope, 2 suggestions to add the uuid as fallback.

packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrEditSharedFolderModal.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/CreateOrEditSharedFolderModal.tsx Outdated Show resolved Hide resolved
@Tbaut Tbaut merged commit fccae7d into dev Aug 3, 2021
@Tbaut Tbaut deleted the feat/bucket-users-meta-1266 branch August 3, 2021 19:45
@FSM1 FSM1 mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 Awaiting requested review from FSM1

@asnaith asnaith Awaiting requested review from asnaith

Assignees

@RyRy79261 RyRy79261

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show usernames or addresses for users in shared folder update modal The user bubbles don't show the nickname
3 participants
@RyRy79261 @tanmoyAtb @Tbaut