Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy/Move to shared folder #1396

Merged
merged 14 commits into from
Aug 4, 2021
Merged

Copy/Move to shared folder #1396

merged 14 commits into from
Aug 4, 2021

Conversation

tanmoyAtb
Copy link
Contributor

closes #1265

@render
Copy link

render bot commented Aug 3, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1396.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c44m3i1t9ds8sa1cmrog.

@render
Copy link

render bot commented Aug 3, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1396.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c44m3ipt9ds8sa1cms50.

@render
Copy link

render bot commented Aug 3, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1396.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c44m3j9t9ds8sa1cmseg.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Aug 3, 2021
@asnaith
Copy link
Member

asnaith commented Aug 4, 2021

Awesome. I just tested out the below scenarios and are all are working great

🟩 User can share to existing shared folder and delete original file
🟩 User can share to existing shared folder and keep original file
🟩 User can share to a new shared folder and delete original file
🟩 User can share to a new shared folder and keep original file

Tbaut
Tbaut approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working well, just a translation missing :)

packages/files-ui/src/Components/Modules/FileBrowsers/ShareToSharedFolderModal.tsx Outdated Show resolved Hide resolved
@Tbaut Tbaut enabled auto-merge (squash) August 4, 2021 12:00
@Tbaut Tbaut merged commit fbf4d29 into dev Aug 4, 2021
@Tbaut Tbaut deleted the feat/move-copy-shared-folder-1265 branch August 4, 2021 12:00
@FSM1 FSM1 mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@FSM1 FSM1 FSM1 approved these changes

@Tbaut Tbaut Tbaut approved these changes

Assignees
No one assigned
Labels
Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to shared folder
6 participants
@tanmoyAtb @asnaith @RyRy79261 @FSM1 @Tbaut @actions-user