Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FILES] Ensure content type is retained when sharing #1407

Merged
merged 3 commits into from
Aug 4, 2021
Merged

[FILES] Ensure content type is retained when sharing #1407

merged 3 commits into from
Aug 4, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Aug 4, 2021

Closes #1399

@FSM1 FSM1 requested a review from Tbaut August 4, 2021 13:29
@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Aug 4, 2021
@FSM1 FSM1 self-assigned this Aug 4, 2021
@render
Copy link

render bot commented Aug 4, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1407.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c459clpt9ds8sa1dg9fg.

@render
Copy link

render bot commented Aug 4, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1407.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c459cm9t9ds8sa1dga00.

@render
Copy link

render bot commented Aug 4, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1407.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c459cmpt9ds8sa1dga9g.

Tbaut
Tbaut approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, working perfectly!

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Aug 4, 2021
tanmoyAtb
tanmoyAtb approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Tbaut Tbaut enabled auto-merge (squash) August 4, 2021 16:15
@Tbaut Tbaut merged commit d4207da into dev Aug 4, 2021
@Tbaut Tbaut deleted the fix/file-format-not-supported-1399 branch August 4, 2021 16:16
@FSM1 FSM1 mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith Awaiting requested review from asnaith

@RyRy79261 RyRy79261 Awaiting requested review from RyRy79261

Assignees

@FSM1 FSM1

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shared jpeg image can't be open "file format not supported" renaming to jpg works
3 participants
@FSM1 @tanmoyAtb @Tbaut