Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using default cursors #1411

Merged
merged 7 commits into from
Aug 6, 2021
Merged

Using default cursors #1411

merged 7 commits into from
Aug 6, 2021

Conversation

tanmoyAtb
Copy link
Contributor

closes #1408

@render
Copy link

render bot commented Aug 4, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1411.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c45e20k7o9q5la7f56c0.

@render
Copy link

render bot commented Aug 4, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1411.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c45e2147o9q5la7f56lg.

@render
Copy link

render bot commented Aug 4, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1411.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c45e21k7o9q5la7f5720.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Aug 4, 2021
@asnaith
Copy link
Member

asnaith commented Aug 5, 2021 •
edited
Loading

Hey Tanmoy, this looks good in macOS Chrome & Firefox, can see that the cursor is an arrow now when hovering over a folder. It only changes to a pointer when hovering over a checkbox or kebab menu icon which makes sense 🙂

This should reduce some confusion but still might not appease the users who don't like the double click.

A suggestion that might be out of the context of this PR - perhaps we could consider adding a pointer when hovering over the folder name and making the folder name itself a single click to enter the folder? We can keep the double click if a user is hovering on the row. This is how folder navigation works in OneDrive but the current way is more similar to Google Drive. (cc @sweetpea22)

@Tbaut
Copy link
Collaborator

Tbaut commented Aug 5, 2021

@asnaith and @sweetpea22 I agree, let's continue the conversation in #1415

Tbaut
Tbaut requested changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well but I think the implementation can be changed to solve the ground problem rather than overriding it.

...es/files-ui/src/Components/Modules/FileBrowsers/views/FileSystemItem/FileSystemTableItem.tsx Outdated Show resolved Hide resolved
@Tbaut Tbaut added the Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. label Aug 5, 2021
@tanmoyAtb tanmoyAtb requested a review from Tbaut August 5, 2021 14:10
@tanmoyAtb
Copy link
Contributor Author

Hey Tanmoy, this looks good in macOS Chrome & Firefox, can see that the cursor is an arrow now when hovering over a folder. It only changes to a pointer when hovering over a checkbox or kebab menu icon which makes sense 🙂

This should reduce some confusion but still might not appease the users who don't like the double click.

A suggestion that might be out of the context of this PR - perhaps we could consider adding a pointer when hovering over the folder name and making the folder name itself a single click to enter the folder? We can keep the double click if a user is hovering on the row. This is how folder navigation works in OneDrive but the current way is more similar to Google Drive. (cc @sweetpea22)

Yes makes sense! The UX you suggested is also used by dropbox. Will continue in #1415

Tbaut
Tbaut approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Tbaut Tbaut added Status: Review Needed 👀 Added to PRs when they need more review and removed Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. labels Aug 5, 2021
RyRy79261
RyRy79261 reviewed Aug 5, 2021
View reviewed changes
packages/storage-ui/src/Components/Modules/FileSystemItem/FileSystemTableItem.tsx
@@ -171,7 +171,6 @@ const FileSystemTableItem = React.forwardRef(
droppable: isFolder && (isOverMove || isOverUpload)
})}
type="grid"
rowSelectable={true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we still want the rows selectable just with different cursors?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selectable prop from what I could see only changed the cursor and allows an "onClick" prop that we don't use anyway. So having it to false doesn't seem to change the behavior and actually just acts on the cursor for us, which is nice.

@Tbaut Tbaut enabled auto-merge (squash) August 6, 2021 11:05
@Tbaut Tbaut merged commit 2c3c150 into dev Aug 6, 2021
@Tbaut Tbaut deleted the mnt/navigation-cursors-1408 branch August 6, 2021 11:09
@FSM1 FSM1 mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@RyRy79261 RyRy79261 RyRy79261 left review comments

@asnaith asnaith asnaith approved these changes

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change cursors for navigation
4 participants
@tanmoyAtb @asnaith @Tbaut @RyRy79261