-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage: Download functionality on bucket files #1424
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ea53022
Added download in
RyRy79261 8dfea1f
Update packages/storage-ui/src/Components/Pages/BucketPage.tsx
RyRy79261 22aaa75
Update packages/storage-ui/src/Components/Pages/BucketPage.tsx
RyRy79261 9169ba1
Merge branch 'dev' into feat/download-buckets-1418
Tbaut 9fe071d
Merge branch 'dev' into feat/download-buckets-1418
FSM1 439fbc2
Fixed spacing
RyRy79261 cf58211
Merge branch 'feat/download-buckets-1418' of github.com:ChainSafe/fil…
RyRy79261 acec9f2
Resting to changes from dev
RyRy79261 174d4a2
Simple overflow patch
RyRy79261 330cd43
Merge branch 'dev' into feat/download-buckets-1418
Tbaut 92ce96f
fix the overflow
Tbaut 3764d08
Merge branch 'dev' into feat/download-buckets-1418
Tbaut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tbaut What was discussed regarding downloads? The ticket seemed straighforward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the comments, the description was subsequently updated. #1418
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I should hide the progress bar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, the idea was to not handle the download in js, but rather download the file using a gateway directly. So get the cid, triggers a browser download (with a
<a download=
or something similar).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But again, I'm not willing to fight for this. Feel free to re-open, I'd approve the PR.