Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose decryption key #1426

Merged
merged 13 commits into from
Aug 10, 2021
Merged

Expose decryption key #1426

merged 13 commits into from
Aug 10, 2021

Conversation

RyRy79261
Copy link
Contributor

closes #1392

@RyRy79261 RyRy79261 added the Status: Review Needed 👀 Added to PRs when they need more review label Aug 6, 2021
@RyRy79261 RyRy79261 self-assigned this Aug 6, 2021
@render
Copy link

render bot commented Aug 6, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1426.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c46keosobjd906i9lfa0.

@render
Copy link

render bot commented Aug 6, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1426.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c46kepcobjd906i9lfmg.

@render
Copy link

render bot commented Aug 6, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1426.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c46kepsobjd906i9lg00.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Aug 6, 2021
Tbaut
Tbaut requested changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works well. I left some comments to get a better readability.
Also idk if you saw but @FSM1 already added an eye icon for the api keys for storage in the past, it's not used any more but the eye (at least the open one) is still there.

packages/common-components/src/ToggleHiddenText/ToggleHiddenText.tsx Outdated Show resolved Hide resolved
packages/common-components/src/ToggleHiddenText/ToggleHiddenText.tsx Outdated Show resolved Hide resolved
packages/common-components/src/ToggleHiddenText/ToggleHiddenText.tsx Outdated Show resolved Hide resolved
packages/files-ui/src/Components/Modules/FileBrowsers/FileInfoModal.tsx Outdated Show resolved Hide resolved
packages/common-components/src/ToggleHiddenText/ToggleHiddenText.tsx Outdated Show resolved Hide resolved
packages/common-components/src/ToggleHiddenText/ToggleHiddenText.tsx Outdated Show resolved Hide resolved
RyRy79261 and others added 7 commits August 10, 2021 11:50
@RyRy79261 @Tbaut
Update packages/common-components/src/ToggleHiddenText/ToggleHiddenTe…
0da2a2d 
…xt.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@RyRy79261 @Tbaut
Update packages/files-ui/src/Components/Modules/FileBrowsers/FileInfo…
310bfdf 
…Modal.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@RyRy79261 @Tbaut
Update packages/common-components/src/ToggleHiddenText/ToggleHiddenTe…
b6ff171 
…xt.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@RyRy79261 @asnaith
Update packages/files-ui/src/Components/Modules/FileBrowsers/FileInfo…
d72a0f5 
…Modal.tsx

Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com>
@RyRy79261 @Tbaut
Update packages/common-components/src/ToggleHiddenText/ToggleHiddenTe…
c7fabe7 
…xt.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@actions-user
lingui extract
96f1c52
@RyRy79261
Cleaned
3a73f19
Tbaut
Tbaut approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tbaut Tbaut merged commit 46bef83 into dev Aug 10, 2021
@Tbaut Tbaut deleted the feat/show-decrypt-key-1392 branch August 10, 2021 14:37
@FSM1 FSM1 mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

@asnaith asnaith Awaiting requested review from asnaith

Assignees

@RyRy79261 RyRy79261

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose the decryption key in the file info (hidden by default)
5 participants
@RyRy79261 @asnaith @FSM1 @Tbaut @actions-user