Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Adapt the email login from like done on Files #1427

Merged
merged 5 commits into from
Aug 10, 2021
Merged

[Storage] Adapt the email login from like done on Files #1427

merged 5 commits into from
Aug 10, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Aug 6, 2021

followup up from #1352

@render
Copy link

render bot commented Aug 6, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1427.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c46l17kobjd906i9lv8g.

@render
Copy link

render bot commented Aug 6, 2021

Your Render PR Server URL is https://gaming-ui-stage-pr-1427.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c46l184objd906i9lvl0.

@render
Copy link

render bot commented Aug 6, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1427.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c46l18kobjd906i9lvug.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Aug 6, 2021
@asnaith
Copy link
Member

asnaith commented Aug 7, 2021

Looking good. The Ethereum logo is missing from the "Continue with Web3 wallet" button at the moment but everything else is working well 🙂

Screen Shot 2021-08-06 at 8 05 12 PM

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Aug 9, 2021
@Tbaut
Copy link
Collaborator Author

Tbaut commented Aug 9, 2021

The ETH logo is there now thanks @asnaith

FSM1
FSM1 approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🥇

@Tbaut Tbaut enabled auto-merge (squash) August 10, 2021 15:25
@Tbaut Tbaut merged commit a43c72c into dev Aug 10, 2021
@Tbaut Tbaut deleted the feat/tbaut-new-email-flow branch August 10, 2021 17:06
@FSM1 FSM1 mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@asnaith asnaith asnaith approved these changes

@RyRy79261 RyRy79261 Awaiting requested review from RyRy79261

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tbaut @asnaith @FSM1 @actions-user