-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User lookup consent #1737
User lookup consent #1737
Conversation
Your Render PR Server URL is https://files-ui-stage-pr-1737.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c67647t0mal5mpopmpq0. |
Your Render PR Server URL is https://gaming-ui-stage-pr-1737.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c67648d0mal5mpopmqbg. |
Your Render PR Server URL is https://storage-ui-stage-pr-1737.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c67648t0mal5mpopmql0. |
This is working well, we just need to ensure we remember to test the ability to uncheck to remove yourself from lookup once the API issue is resolved. To test the scenario when it's not enabled I used a brand new account. Whilst doing this I also noticed that until lookup via share key does not work until consent is checked. I'm not sure if this is intended? Only wallet address and username are mentioned on the label. I'll add the below scenarios to our documentation.
...and I'll add a scenario for the expected share key too once expected behaviour is confirmed :) |
Tested this now and all is resolved.
@ohmpatel1997 @dhyaniarun1993 Is this the correct behavior of the user lookup endpoint? If so, we should update the label of the checkbox. |
I think thats expected, since the flag should work like a global permission to make themselves searchable. do we want to change this? |
No need, I will just update the label to more accurately reflect what the checkbox does. Just wanted to make sure that this was intended behavior. There were a lot of discussions around whether lookup by the User Pub Key were to be allowed even if the lookup flag was set to false. |
@kalambet @dhyaniarun1993 yours will be the final call, what do you think? |
Yep. I agree there should be only 1 flag that decide if user is searchable or not |
closes #1601
There is currently a known issue at the API, which does not allow for turning the flag tofalse
but this is being investigated by the API team.API Issue has now been resolved