Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back signout menu on mobile #1812

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Bring back signout menu on mobile #1812

merged 1 commit into from
Dec 7, 2021

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Dec 7, 2021 •
edited
Loading

This fixes the test

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Dec 7, 2021
@Tbaut Tbaut requested review from tanmoyAtb and FSM1 December 7, 2021 14:30
@render
Copy link

render bot commented Dec 7, 2021

Your Render PR Server URL is https://files-billing-stage-pr-1812.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6nn02t0mal1fu3putgg.

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Dec 7, 2021
FSM1
FSM1 approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this 🎉

@FSM1 FSM1 merged commit 3512dd1 into epic/files-billing Dec 7, 2021
@FSM1 FSM1 deleted the fix/tbaut-bring-back-signout-mobile branch December 7, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tbaut @FSM1