Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default card #1814

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Remove default card #1814

merged 2 commits into from
Dec 8, 2021

Conversation

tanmoyAtb
Copy link
Contributor

@tanmoyAtb tanmoyAtb commented Dec 8, 2021

closes #1799


Submission checklist:

Layout

  • Change looks good in the desktop web ui
    • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Dec 8, 2021

@tanmoyAtb tanmoyAtb requested a review from FSM1 December 8, 2021 06:01
@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Dec 8, 2021
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a forgotten Trans, the rest is perfect.

@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Dec 8, 2021
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🔥

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@FSM1 FSM1 merged commit 1984d36 into epic/files-billing Dec 8, 2021
@FSM1 FSM1 deleted the feat/remove-default-card-1799 branch December 8, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants