Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show information when there are no notifications #1833

Merged
merged 7 commits into from
Jan 4, 2022
Merged

Show information when there are no notifications #1833

merged 7 commits into from
Jan 4, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Dec 17, 2021 •
edited
Loading

closes #1821

TODO:

  • Add the image in high res , I used the bell icon for now

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Dec 17, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1833.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6u8mv1t9dsag3hkda90.

@render
Copy link

render bot commented Dec 17, 2021

Your Render PR Server URL is https://chainsafe-components-stage-pr-1833.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6u8mvht9dsag3hkdalg.

@render
Copy link

render bot commented Dec 17, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1833.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c6u8n01t9dsag3hkdaq0.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Dec 17, 2021
@Tbaut Tbaut added the Status: Review Needed 👀 Added to PRs when they need more review label Dec 17, 2021
@asnaith
Copy link
Member

asnaith commented Dec 18, 2021

Working well.

I thought the background colour of the notification area could perhaps be a little lighter, what do you think? I can see the shadow but its colour is quite close to the regular background (looks good on hover though).

Screen Shot 2021-12-17 at 7 57 33 PM

tanmoyAtb
tanmoyAtb approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than the dark mode point ! would be good to get that in.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jan 3, 2022

added the high res icon and some lighter background, it's looking better I think.
image
image

@tanmoyAtb
Copy link
Contributor

added the high res icon and some lighter background, it's looking better I think. image image

I would add some padding between the icon and the "There are no notifications" text.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Jan 4, 2022

here we go
image

@tanmoyAtb tanmoyAtb merged commit 5551262 into dev Jan 4, 2022
@tanmoyAtb tanmoyAtb deleted the mnt/tbaut-notif-1821 branch January 4, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith Awaiting requested review from asnaith

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nice notification image when there's nothing to show
4 participants
@Tbaut @asnaith @tanmoyAtb @actions-user