-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile and username add tests #1834
Conversation
Your Render PR Server URL is https://storage-ui-stage-pr-1834.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c70dn6sobjd0h7mbd3q0. |
Your Render PR Server URL is https://chainsafe-components-stage-pr-1834.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c70dn7cobjd0h7mbd46g. |
Your Render PR Server URL is https://files-ui-stage-pr-1834.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c70dn7kobjd0h7mbd4b0. |
…afe/ui-monorepo into mnt/username-names-edit-test-1830
Everything seems to be working well, But |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use the Cypress interface, relaunching with the refresh button will not refresh the session. I guess the auto-reload function when the code changes does the same, the user will be logged in, and the sessions re-used. I launched it locally to check and can attest there's a new user created, with a new username, and all was green when launched for the first time.
If you want to test this locally, you need to close the browser (chrome) and relaunch the test manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small suggestion.
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Ah yes, I can see how this would cause an issue when repeating the test within the same session but this is just something we do in development whilst creating the test. I wrap the When it's running as part of the suite that gets executed against PRs we will be fine 😊 |
This is great Tanmoy, an excellent first foray into UI test writing! Thanks for this 🙏 |
closes #1830