Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie banner styling #1855

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Cookie banner styling #1855

merged 3 commits into from
Jan 14, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #1845


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Jan 13, 2022

@render
Copy link

render bot commented Jan 13, 2022

@render
Copy link

render bot commented Jan 13, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jan 13, 2022
@tanmoyAtb tanmoyAtb changed the title cookie banner styling Cookie banner styling Jan 13, 2022
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@asnaith
Copy link
Member

asnaith commented Jan 14, 2022

Oops, I couldn't work out how to test this 🤦‍♂️

Cleared my browser, tried editing local storage etc but could not get it to show. Any tips?

@Tbaut
Copy link
Collaborator

Tbaut commented Jan 14, 2022

Showing the banner is quite a long process, where it first checks that the posthog is initialized etc. This is something we don't have in render to prevent having our tests in the analytics. The easiest to test it would then be to edit the code here https://github.com/ChainSafe/ui-monorepo/blob/dev/packages/files-ui/src/Contexts/PosthogContext.tsx#L97 and make sure you're in a private tab.

@tanmoyAtb tanmoyAtb enabled auto-merge (squash) January 14, 2022 13:51
@FSM1
Copy link
Contributor

FSM1 commented Jan 14, 2022

Showing the banner is quite a long process, where it first checks that the posthog is initialized etc. This is something we don't have in render to prevent having our tests in the analytics. The easiest to test it would then be to edit the code here https://github.com/ChainSafe/ui-monorepo/blob/dev/packages/files-ui/src/Contexts/PosthogContext.tsx#L97 and make sure you're in a private tab.

Managed to successfully test this on local by adding the necessary ENV variables:

REACT_APP_POSTHOG_PROJECT_API_KEY=phc_aHikZYLRMFBEPbBokafenhasCyfS7YSalx7rgsHwfXR
REACT_APP_POSTHOG_INSTANCE_ADDRESS=https://posthog.chainsafe.io

image

@tanmoyAtb tanmoyAtb merged commit e7696e3 into dev Jan 14, 2022
@tanmoyAtb tanmoyAtb deleted the fix/cookie-banner-view-1845 branch January 14, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie notification overlapping
4 participants