-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to go back to crypto payment #1859
Conversation
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
…Tab/ChangePlan/CryptoPayment.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…fe/ui-monorepo into feat/crypto-payment-1782
…norepo into feat/crypto-payment-1782
Your Render PR Server URL is https://storage-ui-stage-pr-1859.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7grlps6fj38fb3n7kkg. |
Your Render PR Server URL is https://chainsafe-components-stage-pr-1859.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7grlqc6fj38fb3n7l10. |
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/CryptoPayment.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
Agreed, the users should know before clicking the "Change plan". I'll add a button there. |
I pushed a really small commit, for the go back button style in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working really well, missed a few translations which I have added suggestions for.
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
I added the same loading button on the subscription page (effectively under the new plan, than is awaiting a payment). It still feels a little weird to me to have a loader on a button, but I can't come up with something better, and I guess it does the job for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall functionality is great !
But you're right UX could improve. What comes to my mind,
Show the current plan like this
Standard plan (awaiting payment confirmation)
Show a see pending invoice
button below, remove the change plan modal view.
This we can do now
Asking them to see below would not be a better UX IMHO. I think what could be improved would be to take them directly to the pending crypto payment info, and skip the plan selection. I can certainly hack that in now. Let me give it a go before we merge. |
Thats sounds much better. In stead of showing plan selection again, directly show the invoice details :+1 |
Ok here we go I ditched the loading circle all together, ping @serenaho outstanding.mp4 |
closes #1846
Submission checklist:
Layout
Theme