-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Billing notifications #1861
Billing notifications #1861
Conversation
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
…Tab/ChangePlan/CryptoPayment.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…fe/ui-monorepo into feat/crypto-payment-1782
This reverts commit 74ddf46.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks 🚀 to go !
Hey Mike, should we be able to verify this by modifying the responses on That was the most logical way I could think of testing. However, I got the traffic routing through Charles Proxy and set a breakpoint on |
Yeah! Thank you for the tips, it's looking good
Ok 👍
|
This pull request introduces 2 alerts when merging c07340d into 7cb726c - view on LGTM.com new alerts:
|
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
This pull request introduces 2 alerts when merging 2cccf99 into 7cb726c - view on LGTM.com new alerts:
|
…ChainSafe/ui-monorepo into feat/billing-notifications-1819
I didn't play with it yet, but the code looks good. |
closes #1819
Submission checklist:
Layout
Change looks good in the mobile web ui- Currently N/A as the mobile notification area still needs to be designed and implemented.Theme