Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal styles consistency #1862

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Modal styles consistency #1862

merged 4 commits into from
Jan 19, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #1729

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Jan 18, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1862.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7jhn33vog4uhtsli8s0.

@render
Copy link

render bot commented Jan 18, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1862.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7jhn3jvog4uhtsli98g.

@render
Copy link

render bot commented Jan 18, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1862.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7jhn43vog4uhtsli9d0.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jan 18, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 18, 2022

This pull request introduces 2 alerts when merging c2ad388 into c79b2f5 - view on LGTM.com

new alerts:

  • 2 for Useless conditional

asnaith
asnaith approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modals are looking great now 😎

FSM1
FSM1 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @tanmoyAtb 🎉

@tanmoyAtb tanmoyAtb merged commit bd91921 into dev Jan 19, 2022
@tanmoyAtb tanmoyAtb deleted the mnt/modal-styles-1729 branch January 19, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnaith asnaith asnaith approved these changes

@FSM1 FSM1 FSM1 approved these changes

@Tbaut Tbaut Awaiting requested review from Tbaut

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent style on modals (mobile)
4 participants
@tanmoyAtb @asnaith @FSM1 @actions-user