Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay Invoice #1866

Merged
merged 76 commits into from
Jan 27, 2022
Merged

Pay Invoice #1866

merged 76 commits into from
Jan 27, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jan 19, 2022

closes #1829
closes #1873

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

FSM1 and others added 30 commits December 16, 2021 16:12
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
…Tab/ChangePlan/CryptoPayment.tsx

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request introduces 10 alerts when merging 66d757e into 0dc1f80 - view on LGTM.com

new alerts:

  • 8 for Assignment to constant
  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@FSM1 FSM1 marked this pull request as ready for review January 24, 2022 17:06
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great 💯 . just a couple of nits

@FSM1 FSM1 requested a review from Tbaut January 25, 2022 20:12
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my previously added then removed code causes a lot of headaches :D

Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more nits, and we'll be good to go :)

@FSM1 FSM1 requested a review from Tbaut January 26, 2022 13:45
FSM1 and others added 2 commits January 26, 2022 15:52
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and keep an eye on isPendingInvoice and pendingCryptoInvoice that are somewhat overlapping.

@Tbaut Tbaut merged commit 5eb2821 into dev Jan 27, 2022
@Tbaut Tbaut deleted the feat/pay-invoice-1829 branch January 27, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert to yearly plan before deployment Allow payment of invoice on demand
4 participants