-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pay Invoice #1866
Pay Invoice #1866
Conversation
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
…Tab/ChangePlan/CryptoPayment.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
…fe/ui-monorepo into feat/crypto-payment-1782
…norepo into feat/crypto-payment-1782
This pull request introduces 10 alerts when merging 66d757e into 0dc1f80 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great 💯 . just a couple of nits
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/CurrentPlan.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
…ui-monorepo into feat/pay-invoice-1829
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/CurrentPlan.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my previously added then removed code causes a lot of headaches :D
...ages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/ChangePlanModal.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/ChangePlan/SelectPlan.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more nits, and we'll be good to go :)
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/BillingHistory.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/BillingHistory.tsx
Outdated
Show resolved
Hide resolved
packages/files-ui/src/Components/Modules/Settings/SubscriptionTab/BillingHistory.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and keep an eye on isPendingInvoice
and pendingCryptoInvoice
that are somewhat overlapping.
closes #1829
closes #1873
Submission checklist:
Layout
Theme