[Fix] Remove the artificial 65 char limit and fix caption on black theme #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://storage-ui-stage-pr-1876.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7nbogc41lsb0l4t39vg. |
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-1876.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7nboh441lsb0l4t3ac0. |
|
Your Render PR Server URL is https://files-ui-stage-pr-1876.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7nbohk41lsb0l4t3ahg. |
github-actions
bot
added
the
Type: Bug Fix
Tbaut
changed the title
asnaith
reviewed
Jan 24, 2022
| @@ -196,7 +196,7 @@ describe("File management", () => { | |||
| }) | |||
|
|
|||
| it("can rename a file with error handling", () => { | |||
| const newName = "awesome new name" | |||
| const newName = "awesome new name that is pretty long and it shouldn't matter that much anyway" | |||
asnaith
approved these changes
Jan 24, 2022
FSM1
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1874
after some tests, it seems that the limit in the name isn't enforced by the api side, for folders or shared folders (buckets) so I removed them all. While testing in dark mode I realize than we had a certainly long standing issue where the error message weren't readable, black on black. That's also fixed now
Before:
After
Submission checklist:
Layout
Theme