Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invoice detail fields to Invoice Item #1886

Merged
merged 10 commits into from
Jan 31, 2022
Merged

Add invoice detail fields to Invoice Item #1886

merged 10 commits into from
Jan 31, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jan 27, 2022 •
edited
Loading

closes #1870

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Jan 27, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1886.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7pb1jv6d9kkk0t70nmg.

@render
Copy link

render bot commented Jan 27, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1886.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7pb1kf6d9kkk0t70o3g.

@render
Copy link

render bot commented Jan 27, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1886.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7pb1l76d9kkk0t70o80.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Jan 27, 2022
@FSM1 FSM1 changed the title Translated using Weblate (French) (#1883) Add invoice detail fields to Invoice Item Jan 28, 2022
@FSM1 FSM1 self-assigned this Jan 28, 2022
@FSM1 FSM1 added the Status: Review Needed 👀 Added to PRs when they need more review label Jan 28, 2022
@FSM1 FSM1 marked this pull request as ready for review January 28, 2022 15:11
@asnaith
Copy link
Member

asnaith commented Jan 29, 2022

I noticed some minor alignment issues but other than that looks great.

Screen Shot 2022-01-28 at 8 02 08 PM

PS I found another bug with the pay now link but I've created a separate issue as noticed it was pre-existing #1891

Tbaut
Tbaut reviewed Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stumbled upon what Andrew mentioned, other than that it looks good!

packages/files-ui/src/Components/Elements/InvoiceLines.tsx Outdated Show resolved Hide resolved
@FSM1
Copy link
Contributor Author

FSM1 commented Jan 31, 2022

I noticed some minor alignment issues but other than that looks great.

Resolved 🎉

@tanmoyAtb
Copy link
Contributor

I noticed that the view pdf button isn't firing. Sth to do with the button variant changes.

@FSM1
Copy link
Contributor Author

FSM1 commented Jan 31, 2022

I noticed that the view pdf button isn't firing. Sth to do with the button variant changes.

Were you testing on local or Render? If on local, you need to rebuild the common components.

@tanmoyAtb
Copy link
Contributor

I noticed that the view pdf button isn't firing. Sth to do with the button variant changes.

Were you testing on local or Render? If on local, you need to rebuild the common components.

Ahh yes. Forgot to build on the PR. 👍

@FSM1 FSM1 enabled auto-merge (squash) January 31, 2022 23:12
@FSM1 FSM1 merged commit 3d0d0a7 into dev Jan 31, 2022
@FSM1 FSM1 deleted the feat/invoice-details-display-1870 branch January 31, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut left review comments

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith asnaith approved these changes

Assignees

@FSM1 FSM1

Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Invoice Line Item
5 participants
@FSM1 @asnaith @tanmoyAtb @Tbaut @actions-user