Fix placeholder in dark mode and cleanup #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://storage-ui-stage-pr-1887.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7pbh0hg7hpcl7l3n9cg. |
|
Your Render PR Server URL is https://chainsafe-components-stage-pr-1887.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7pbh11g7hpcl7l3n9p0. |
|
Your Render PR Server URL is https://files-ui-stage-pr-1887.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c7pbh1hg7hpcl7l3n9vg. |
github-actions
bot
added
the
Type: Bug Fix
|
Nice fix and good find, looks like it was only affecting firefox. |
asnaith
approved these changes
Jan 27, 2022
tanmoyAtb
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1888
closes a bug where placeholder were invisible in dark mode
Also removes a bunch of unused components (lost quite some time changing things in there before realizing this component wasn't the right one)
Before:
After
Submission checklist:
Layout
Theme