Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No search results response handle #1896

Merged
merged 4 commits into from
Feb 1, 2022
Merged

No search results response handle #1896

merged 4 commits into from
Feb 1, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #1894

@render
Copy link

render bot commented Jan 31, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-1896.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7s1nuk6fj34kjn3845g.

@render
Copy link

render bot commented Jan 31, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-1896.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7s1nv46fj34kjn384i0.

@render
Copy link

render bot commented Jan 31, 2022

Your Render PR Server URL is https://files-ui-stage-pr-1896.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7s1nvs6fj34kjn384mg.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jan 31, 2022
@asnaith
Copy link
Member

asnaith commented Jan 31, 2022

Nice fix, I'm no longer seeing the crash. 👍

I am seeing duplicate toasts though, is this related or should I create a separate issue for this?

Screen.Recording.2022-01-31.at.10.04.33.AM.mov

@FSM1
Copy link
Contributor

FSM1 commented Jan 31, 2022 •
edited
Loading

I am seeing duplicate toasts though, is this related or should I create a separate issue for this?

Yeah also just noticed that. At first I thought it was purely the two consecutive calls failing, but turns out the error is thrown because of a empty file system.

@tanmoyAtb
Copy link
Contributor Author

Nice fix, I'm no longer seeing the crash. 👍

I am seeing duplicate toasts though, is this related or should I create a separate issue for this?

Screen.Recording.2022-01-31.at.10.04.33.AM.mov

Good find. I'll check into this as well.

@Tbaut
Copy link
Collaborator

Tbaut commented Feb 1, 2022

TypeError: null has no properties

That's the error in the console

@Tbaut Tbaut added the Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. label Feb 1, 2022
@tanmoyAtb
Copy link
Contributor Author

TypeError: null has no properties

That's the error in the console

Updates are in.

Tbaut
Tbaut approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

packages/files-ui/src/Components/Modules/FileBrowsers/SearchFileBrowser.tsx
@@ -63,8 +55,7 @@ const SearchFileBrowser: React.FC<IFileBrowserModuleProps> = ({ controls = false
}
}
onSearch()
// eslint-disable-next-line
}, [searchTerm])
}, [searchTerm, getSearchResults])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Tbaut Tbaut removed the Status: Changes Requested ❌ Added to PRs that require further changes from the contributor. label Feb 1, 2022
@Tbaut Tbaut merged commit 0ba92dc into dev Feb 1, 2022
@Tbaut Tbaut deleted the mnt/no-search-results-1894 branch February 1, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 FSM1 approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle API response when no results with search.
4 participants
@tanmoyAtb @asnaith @FSM1 @Tbaut