Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove general modal buttons when adding/updating a card #1902

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 1, 2022

closes #1897


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 1, 2022

@render
Copy link

render bot commented Feb 1, 2022

@render
Copy link

render bot commented Feb 1, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Feb 1, 2022
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleaner 👍

Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement :)

@tanmoyAtb tanmoyAtb enabled auto-merge (squash) February 2, 2022 05:16
@tanmoyAtb tanmoyAtb merged commit ed85d79 into dev Feb 2, 2022
@tanmoyAtb tanmoyAtb deleted the fix/tbaut-goback-confusion-1897 branch February 2, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Go back" confusion when paying
3 participants