Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time left in crypto payment #1903

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Fix time left in crypto payment #1903

merged 5 commits into from
Feb 3, 2022

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Feb 1, 2022

closes a bug that I noticed recently. If you start a crypto payment, then go back to it 20min later (using the "see payment info" button for instance), the time remaining will correctly show that you have 40min left, but the loading progression will actually be 100%. I fixed this here.


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented Feb 1, 2022

@render
Copy link

render bot commented Feb 1, 2022

@render
Copy link

render bot commented Feb 1, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Feb 1, 2022
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@asnaith
Copy link
Member

asnaith commented Feb 2, 2022

Nice fix, looks good. I had no idea this element was supposed to work like that! 😄

@Tbaut Tbaut enabled auto-merge (squash) February 3, 2022 00:09
@Tbaut Tbaut merged commit 1570a9e into dev Feb 3, 2022
@Tbaut Tbaut deleted the fix/tbaut-time-left branch February 3, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants