Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Posthog to storage #2028

Merged
merged 5 commits into from
Mar 21, 2022
Merged

add Posthog to storage #2028

merged 5 commits into from
Mar 21, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Mar 18, 2022 •
edited
Loading

closes #2026

Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

Billing

  • Change applied to both files-ui and storage-ui

@render
Copy link

render bot commented Mar 18, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2028.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8qaaok6fj39trrsprfg.

@render
Copy link

render bot commented Mar 18, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2028.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8qaapk6fj39trrsprk0.

@render
Copy link

render bot commented Mar 18, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2028.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c8qaaqk6fj39trrsps1g.

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Mar 18, 2022
@FSM1 FSM1 changed the title add psothog to storage add Posthog to storage Mar 21, 2022
@FSM1 FSM1 self-assigned this Mar 21, 2022
Tbaut
Tbaut approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is working great, just a couple nits.

packages/storage-ui/src/Contexts/PosthogContext.tsx Outdated Show resolved Hide resolved
packages/storage-ui/src/Components/Pages/BillingHistory.tsx Show resolved Hide resolved
packages/storage-ui/src/Components/Pages/BucketPage.tsx Show resolved Hide resolved
packages/storage-ui/src/Components/Pages/CidsPage.tsx Outdated Show resolved Hide resolved
@FSM1 @Tbaut
Apply suggestions from code review
ed50458 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
tanmoyAtb
tanmoyAtb approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go 👍

@Tbaut Tbaut enabled auto-merge (squash) March 21, 2022 14:48
@Tbaut Tbaut merged commit cf51853 into dev Mar 21, 2022
@Tbaut Tbaut deleted the feat/storage-posthog-2026 branch March 21, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@Tbaut Tbaut Tbaut approved these changes

@asnaith asnaith Awaiting requested review from asnaith

Assignees

@FSM1 FSM1

Labels
Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Posthog integration for Storage UI
4 participants
@FSM1 @tanmoyAtb @Tbaut @actions-user