Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Restricted mode banner and flow #2031

Merged
merged 7 commits into from
Mar 22, 2022
Merged

Conversation

Tbaut
Copy link
Collaborator

@Tbaut Tbaut commented Mar 21, 2022

closes #2020


Submission checklist:

Layout

  • Change looks good in the desktop web ui

@Tbaut Tbaut requested review from tanmoyAtb and FSM1 March 21, 2022 12:46
@render
Copy link

render bot commented Mar 21, 2022

@render
Copy link

render bot commented Mar 21, 2022

@render
Copy link

render bot commented Mar 21, 2022

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Mar 21, 2022
@Tbaut Tbaut requested a review from asnaith March 21, 2022 12:49
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@asnaith
Copy link
Member

asnaith commented Mar 21, 2022

With the modification of the code, I was able to see the banner and the disabled bucket and pin buttons 👍

The hover color of the button is the same as the banner background.
Screen Shot 2022-03-21 at 2 34 35 PM

As I am forcing restricted mode through code and not the api response I am unable to test the full functionality and see if the banner disappears and the buttons are re-enabled when a user re-adds a card/upgrades their subscription.

I'm wondering if there is any additional info displayed to the user on the settings page, informing them of the specific action they need to take? I don't see additional elements on the settings page and expected something to further explain the reason for the restriction / required action but perhaps because I'm using the code mod to test and not genuine api responses for a restricted user etc.

@FSM1
Copy link
Contributor

FSM1 commented Mar 22, 2022

With the modification of the code, I was able to see the banner and the disabled bucket and pin buttons 👍

The hover color of the button is the same as the banner background. Screen Shot 2022-03-21 at 2 34 35 PM

As I am forcing restricted mode through code and not the api response I am unable to test the full functionality and see if the banner disappears and the buttons are re-enabled when a user re-adds a card/upgrades their subscription.

I'm wondering if there is any additional info displayed to the user on the settings page, informing them of the specific action they need to take? I don't see additional elements on the settings page and expected something to further explain the reason for the restriction / required action but perhaps because I'm using the code mod to test and not genuine api responses for a restricted user etc.

There is currently no additional info displayed. The user would see an unpaid invoice on the settings/billing and I feel that this should be enough for now.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Mar 22, 2022

@asnaith re the hover background, the fact that the text remains white, and therefor visible makes me this that it isn't really a problem 🤷 Let me know your thoughts.

Agreed with Mike that the unpaid invoice (in red) that is visible when you've something to pay, should be enough.

@Tbaut Tbaut merged commit 338a079 into dev Mar 22, 2022
@Tbaut Tbaut deleted the mnt/tbaut-restricted-mode-storage branch March 22, 2022 10:35
@asnaith
Copy link
Member

asnaith commented Mar 22, 2022

@asnaith re the hover background, the fact that the text remains white, and therefor visible makes me this that it isn't really a problem 🤷 Let me know your thoughts.

@Tbaut yeah it's extremely minor and agree it's not a problem at all as it stays visible and functions as intended. I was just pointing it out in case we wanted to add that extra layer of polish to the presentation (I assumed changing it would be as simple as just changing a color hex).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storage] Add support for restricted accounts
5 participants