Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage url update #2056

Merged
merged 7 commits into from
Mar 30, 2022
Merged

stage url update #2056

merged 7 commits into from
Mar 30, 2022

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Mar 30, 2022

Replace references of https://stage.imploy.site/api/v1 with https://stage-api.chainsafe.io/api/v1 + update tests

@render
Copy link

render bot commented Mar 30, 2022

@render
Copy link

render bot commented Mar 30, 2022

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Mar 30, 2022
@render
Copy link

render bot commented Mar 30, 2022

@asnaith
Copy link
Member Author

asnaith commented Mar 30, 2022

I noticed after the URL change that I had to recreate some accounts to fix some failing tests, the accounts being used for lookups no longer existed and none of the share links were valid either. I'm not sure if that was expected after the url switch so I'm leaving this as a draft, maybe this data update was unnecessary?

There are also some legitimate test fails still happening due to the Max plan not being returned in /products atm and most of the subscription-related tests are expecting it.

@asnaith
Copy link
Member Author

asnaith commented Mar 30, 2022

Hmmm I updated the account being used for the storage tests (thought this was the issue) and it passes locally for me but it's still failing in CI. Will look into this more tomorrow.

Bucket management -- desktop -- can create a bucket (failed)

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, having some cors error now, but the changes look good.

@Tbaut
Copy link
Collaborator

Tbaut commented Mar 30, 2022

There was an env set for the github action with the old url. I removed this and it should be fine now.

@asnaith asnaith marked this pull request as ready for review March 30, 2022 15:35
@Tbaut
Copy link
Collaborator

Tbaut commented Mar 30, 2022

many tests are failing.. can't tell why, it seems random..

@asnaith
Copy link
Member Author

asnaith commented Mar 30, 2022

many tests are failing.. can't tell why, it seems random..

@Tbaut Yeah I think it's maybe because the data update - seems like original data was put back since I made the changes and now the new data I created yesterday was wiped. I will try reverting those changes and re-test soon.

@asnaith
Copy link
Member Author

asnaith commented Mar 30, 2022

@FSM1 @Tbaut @tanmoyAtb As expected, I had to revert the data changes I made because the old data returned and the new stuff I had created no longer existed 🙃

The only failures happening now in this branch are related to issues raised on our channel

  • file uploading failing (causing all but one of the fails)
  • invoice response is blank due to missing key in header (don't believe this is something from our side).

Hopefully, once those issues are fixed we can merge this into dev, and then we can update all of the other PRs to bring in these changes.

@Tbaut
Copy link
Collaborator

Tbaut commented Mar 30, 2022

Tbh I'd merge. This will be one pr less. If there's anything we can do later, let's do it in another one.

@asnaith
Copy link
Member Author

asnaith commented Mar 30, 2022

Tbh I'd merge. This will be one pr less. If there's anything we can do later, let's do it in another one.

Sounds good :)

@asnaith asnaith merged commit d263a21 into dev Mar 30, 2022
@asnaith asnaith deleted the mnt/stage-url-update branch March 30, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants