Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Files] Add and improve Spanish translations #2150

Merged
merged 27 commits into from
May 30, 2022
Merged

[Files] Add and improve Spanish translations #2150

merged 27 commits into from
May 30, 2022

Conversation

juans-chainsafe
Copy link
Contributor

closes #2128

@juans-chainsafe juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label May 24, 2022
@juans-chainsafe juans-chainsafe self-assigned this May 24, 2022
@render
Copy link

render bot commented May 24, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2150.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca6gg3fd17c1v8mut410.

@render
Copy link

render bot commented May 24, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2150.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca6gg4nd17c1v8mut45g.

@render
Copy link

render bot commented May 24, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2150.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca6gg5nd17c1v8mut4n0.

Tbaut
Tbaut approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work! Thanks for spoting all these cases without translation.
I left minor comments and suggestions

packages/files-ui/src/locales/de/messages.po Outdated Show resolved Hide resolved
packages/files-ui/src/locales/en/messages.po Outdated Show resolved Hide resolved
packages/files-ui/src/locales/fr/messages.po Outdated Show resolved Hide resolved
packages/files-ui/src/locales/no/messages.po Outdated Show resolved Hide resolved
Tbaut
Tbaut reviewed May 25, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that you were playing with the UI and realized that some element hadn't been translated. I figured you must have looked in the code directly, and indeed those stories files do not need to be updated, that's the reason why lingui, that we use for translation, didn't pick them up, and ended up deleting any translation it didn't know.

packages/common-components/src/stories/Toasts.stories.tsx Outdated Show resolved Hide resolved
packages/common-components/src/stories/Toasts.stories.tsx Outdated Show resolved Hide resolved
packages/common-components/src/stories/Toasts.stories.tsx Outdated Show resolved Hide resolved
packages/common-components/src/stories/Toasts.stories.tsx Outdated Show resolved Hide resolved
packages/common-components/src/stories/Toasts.stories.tsx Outdated Show resolved Hide resolved
packages/common-components/src/stories/Toasts.stories.tsx Outdated Show resolved Hide resolved
@Tbaut
Copy link
Collaborator

Tbaut commented May 25, 2022

BTW I found some other string that hadn't been translated. I pushed it directly

@juans-chainsafe
Copy link
Contributor Author

BTW I found some other string that hadn't been translated. I pushed it directly

I really appreciate that you found the problem! thanks! I will translate the strings that you found

juans-chainsafe and others added 7 commits May 26, 2022 09:42
@juans-chainsafe
undo
7ab73d7
@juans-chainsafe
Merge branch 'dev' into mnt/add-spanish-translations-2128
f391fa9
@juans-chainsafe @Tbaut
Update packages/common-components/src/stories/Toasts.stories.tsx
26298f6 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@juans-chainsafe @Tbaut
Update packages/common-components/src/stories/Toasts.stories.tsx
1d4cb9c 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@juans-chainsafe @Tbaut
Update packages/common-components/src/stories/Toasts.stories.tsx
9b2feda 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@juans-chainsafe @Tbaut
Update packages/common-components/src/stories/Toasts.stories.tsx
ed07011 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@juans-chainsafe @Tbaut
Update packages/common-components/src/stories/Toasts.stories.tsx
48bc46f 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
@lgtm-com
Copy link

lgtm-com bot commented May 26, 2022

This pull request introduces 2 alerts when merging 48bc46f into 47db353 - view on LGTM.com

new alerts:

  • 2 for Syntax error

tanmoyAtb
tanmoyAtb approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! amazing work !

@Tbaut Tbaut merged commit ad165db into dev May 30, 2022
@Tbaut Tbaut deleted the mnt/add-spanish-translations-2128 branch May 30, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

@asnaith asnaith Awaiting requested review from asnaith

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees

@juans-chainsafe juans-chainsafe

Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Files] Add and improve Spanish translations
4 participants
@juans-chainsafe @Tbaut @tanmoyAtb @actions-user