-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix context menu on modals #2154
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2154.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca75ctb97ejc7cgo9ms0. |
Your Render PR Server URL is https://files-ui-stage-pr-2154.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca75cub97ejc7cgo9n0g. |
Your Render PR Server URL is https://storage-ui-stage-pr-2154.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ca75cvb97ejc7cgo9ni0. |
Looks good on the modals now (these right-click changes are so awesome btw!). I noticed the same issue happens on the home page buttons too. Not sure if you want to apply the fix for that in this PR or should we create a new ticket? Screen.Recording.2022-05-25.at.10.35.20.AM.mov |
Awesome! nice, I agree with Andrew, I think the right click should only trigger the context menu INSIDE the table, if we can add that will be great |
definitely in this PR, looking into this. |
…xt-menu-on-modals
…monorepo into fix/context-menu-on-modals
All right. I've prevented right click menu on |
I can't see a commit for this, did you push the changes? also I checked the UI but is still the same as before |
My bad. I pushed the changes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some conflicts snuck in, but I could review and it's working well from my test 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working better now, thanks for the updates! I think once the PR conflict is resolve we can merge it
With the addition of context menu, Right click on any modal that is inside our file browser was opening the context menu.
This PR fixes the issue.
The simple fix was to move the modals out of the
article
component that responds to right click event.