Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared folders overview dropdown overflow fix #2158

Merged
merged 7 commits into from
May 31, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #2079


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

Theme

  • Components / elements inspected in light mode
  • Components / elements inspected in dark mode

@render
Copy link

render bot commented May 27, 2022

@render
Copy link

render bot commented May 27, 2022

@render
Copy link

render bot commented May 27, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label May 27, 2022
@tanmoyAtb tanmoyAtb changed the title overflow height fixed Shared folders overview dropdown overflow fixx May 27, 2022
@tanmoyAtb tanmoyAtb changed the title Shared folders overview dropdown overflow fixx Shared folders overview dropdown overflow fix May 27, 2022
@tanmoyAtb tanmoyAtb marked this pull request as ready for review May 30, 2022 15:12
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! is working perfectly in mobile too

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working perfectly well and the defaultIsOpen can't hurt I guess.

@Tbaut Tbaut merged commit 0c5ef78 into dev May 31, 2022
@Tbaut Tbaut deleted the fix/shared-folders-dropdown-overflow-2079 branch May 31, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown overflow with a long list of shared folders
4 participants