-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out os hidden files #2159
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2159.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caacrmk6fj35onm2aif0. |
Your Render PR Server URL is https://files-ui-stage-pr-2159.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caacrns6fj35onm2aijg. |
Your Render PR Server URL is https://storage-ui-stage-pr-2159.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-caacrp46fj35onm2ajgg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks for this update, working perfect with OS hidden files in Mac, both in Upload modal and doing drag and drop in the file browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great !
closes ##2112
The reason of the behavior is simple, we use 2 different packages.
react-dropzone
in the modal, filter out the files (not the hidden ones, it's only based on the name)https://github.com/react-dropzone/file-selector/blob/master/src/file-selector.ts#L4-L8
react-dnd
for the drag and drop doesn't filter out files.This PR adds the filtering at the root level.