Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav style fixes for storage mobile view #2185

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Nav style fixes for storage mobile view #2185

merged 1 commit into from
Jun 14, 2022

Conversation

tanmoyAtb
Copy link
Contributor

@tanmoyAtb tanmoyAtb commented Jun 13, 2022

closes #2082

Also added in some alignment for buckets page


Submission checklist:

Layout

  • Change looks good in the desktop web ui
  • Change looks good in the mobile web ui

@render
Copy link

render bot commented Jun 13, 2022

@render
Copy link

render bot commented Jun 13, 2022

@render
Copy link

render bot commented Jun 13, 2022

@github-actions github-actions bot added the Type: Bug Fix Added to PRs if they are addressing a bug label Jun 13, 2022
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks much better! and didn't affect the desktop version so nice, good work

IMG_FB297BC28D55-1

@Tbaut Tbaut enabled auto-merge (squash) June 14, 2022 11:04
@Tbaut
Copy link
Collaborator

Tbaut commented Jun 14, 2022

Nice one, as I mentioned in the issue, mobile support for Storage has never really been on the table, if we dig more we will find many more issues on mobile.

@Tbaut Tbaut merged commit c78b15b into dev Jun 14, 2022
@Tbaut Tbaut deleted the fix/nav-styles-2082 branch June 14, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storage] Incorrect colour on slide-out menu elements
3 participants