Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buckets sorting [storage] #2188

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Buckets sorting [storage] #2188

merged 4 commits into from
Jun 15, 2022

Conversation

tanmoyAtb
Copy link
Contributor

closes #2174

I have not placed any sorting by default.
Sorting only triggered on column head clicks.

@render
Copy link

render bot commented Jun 14, 2022

@render
Copy link

render bot commented Jun 14, 2022

@render
Copy link

render bot commented Jun 14, 2022

@github-actions github-actions bot added the Type: Feature Added to PRs to identify that the change is a new feature. label Jun 14, 2022
@tanmoyAtb tanmoyAtb marked this pull request as ready for review June 14, 2022 16:17
Copy link
Member

@asnaith asnaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is a nice improvement, working great in chrome and firefox

@juans-chainsafe
Copy link
Contributor

Working great! good job

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a nit

packages/storage-ui/src/Components/Pages/BucketsPage.tsx Outdated Show resolved Hide resolved
@tanmoyAtb tanmoyAtb merged commit 024743b into dev Jun 15, 2022
@tanmoyAtb tanmoyAtb deleted the feat/buckets-sort-2174 branch June 15, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storage] Add sort in Buckets table
4 participants