Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort CIDs table test #2208

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Sort CIDs table test #2208

merged 5 commits into from
Jun 30, 2022

Conversation

juans-chainsafe
Copy link
Contributor

@juans-chainsafe juans-chainsafe commented Jun 29, 2022 •
edited
Loading

closes #2203

I didn't do the sort by size because sometimes the second cid is not pinned at time and in that case doesn't show the size of that cid

@juans-chainsafe juans-chainsafe added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jun 29, 2022
@juans-chainsafe juans-chainsafe self-assigned this Jun 29, 2022
@juans-chainsafe juans-chainsafe linked an issue Jun 29, 2022 that may be closed by this pull request
[Storage] Sort columns in CIDs view test #2203
Closed
@render
Copy link

render bot commented Jun 29, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2208.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cau4tssobjdelucr4d8g.

@render
Copy link

render bot commented Jun 29, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2208.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cau4tucobjdelucr4ddg.

@render
Copy link

render bot commented Jun 29, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2208.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cau4tvkobjdelucr4dvg.

@juans-chainsafe juans-chainsafe changed the title Mnt/sort columns cids view test 2203 Sort CIDs table test Jun 29, 2022
@juans-chainsafe juans-chainsafe marked this pull request as ready for review June 29, 2022 13:10
tanmoyAtb
tanmoyAtb approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good !

FSM1
FSM1 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working really nicely 🎉

@Tbaut Tbaut merged commit 6a964b2 into dev Jun 30, 2022
@Tbaut Tbaut deleted the mnt/sort-columns-cids-view-test-2203 branch June 30, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 FSM1 approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

Assignees

@juans-chainsafe juans-chainsafe

Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Storage] Sort columns in CIDs view test
4 participants
@juans-chainsafe @tanmoyAtb @FSM1 @Tbaut