Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide NFTs page by default #2244

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Hide NFTs page by default #2244

merged 2 commits into from
Aug 12, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Aug 10, 2022

Hid the NFT page from the nav bar - this is a temporary measure until the NFT code is ready for prime time. Pages for listing and creation are accessible if the url is entered manually.

@render
Copy link

render bot commented Aug 10, 2022

@FSM1 FSM1 requested a review from tanmoyAtb August 10, 2022 13:44
@render
Copy link

render bot commented Aug 10, 2022

@render
Copy link

render bot commented Aug 10, 2022

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Aug 10, 2022
@FSM1 FSM1 self-assigned this Aug 10, 2022
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need a quick one, then it looks good, just a comment to fix linting

packages/storage-ui/src/Components/Layouts/AppNav.tsx Outdated Show resolved Hide resolved
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! and working well

@FSM1 FSM1 merged commit 3a13489 into dev Aug 12, 2022
@FSM1 FSM1 deleted the mnt/hide-nfts-page branch August 12, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants