Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CustomAuth to latest version #2255

Merged
merged 3 commits into from
Oct 11, 2022
Merged

update CustomAuth to latest version #2255

merged 3 commits into from
Oct 11, 2022

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Oct 11, 2022 •
edited
Loading

Update @toruslabs/customAuth to latest version and provide a chainstack Ropsten RPC to resolve Torus Testnet login

@render
Copy link

render bot commented Oct 11, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2255.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cd2lh8da499e6eog6vh0.

@render
Copy link

render bot commented Oct 11, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2255.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cd2lh9ta499e6eog6vug.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Oct 11, 2022
@render
Copy link

render bot commented Oct 11, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2255.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cd2lhbda499e6eog70g0.

@FSM1 FSM1 self-assigned this Oct 11, 2022
Tbaut
Tbaut approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, Lint is not happy for 2 small things, and the tests look good so far :)

@FSM1
Copy link
Contributor Author

FSM1 commented Oct 11, 2022

Code looks good, Lint is not happy for 2 small things, and the tests look good so far :)

Fixed linting properly this time

@FSM1 FSM1 enabled auto-merge (squash) October 11, 2022 13:06
juans-chainsafe
juans-chainsafe approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the issue for login is not longer present, thanks for fixing this!

@FSM1 FSM1 merged commit 7765312 into dev Oct 11, 2022
@FSM1 FSM1 deleted the mnt/update-custom-auth branch October 11, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@juans-chainsafe juans-chainsafe juans-chainsafe approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

@asnaith asnaith Awaiting requested review from asnaith

Assignees

@FSM1 FSM1

Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FSM1 @Tbaut @juans-chainsafe