Multiple changes #101
Multiple changes #101
Conversation
raddatzk
commented
Nov 26, 2019
raddatzk
commented
- add the missing GetCompositeSchedule feature
- add some missing create(default)Request/Confirmation methods
- mark the ZeroArgsConstructor as deprecated in favor of the new Constructor with all required arguments
- Replace Calendar with ZonedDateTime (BREAKING CHANGE in API)
- add a missing dependency for SOAP (didn't want to compile without 🤔
|
Hi @kevinraddatz, Thanks for your PR, it's a big one! 😃 It's going to take me some time to review, but I'll get to it as soon as I have time. |
|
Sorry for the slow pace. It's a busy week for me, but I'll probably have time monday. |
|
No problem, take your time :) |
| features.add(new ClearChargingProfileFeature(this)); | ||
| features.add(new ClearChargingProfileFeature(null)); | ||
| features.add(new GetCompositeScheduleFeature(null)); | ||
| features.add(new SetChargingProfileFeature(null)); |
| features.add(new TriggerMessageFeature(this)); | ||
| } | ||
| features = new HashSet<>(); | ||
| features.add(new TriggerMessageFeature(null)); |
| features.add(new ReserveNowFeature(this)); | ||
| features.add(new CancelReservationFeature(this)); | ||
| features.add(new ReserveNowFeature(null)); | ||
| features.add(new CancelReservationFeature(null)); |
|
I set them to null as it seemed like "this" is only required on features that need to be handled by an event handler. The ReserveNow feature for example does not need to be handled on the server so I thought it can be null. |
|
I get an error when I try to build and test it with maven. Have you tried that? |
|
Check it out: https://travis-ci.org/ChargeTimeEU/Java-OCA-OCPP/jobs/619203910 |
|
Got Travis CI working again (wierd gradle permission problem). You probably have to merge in my changes to .travis.yml to make it pass. |
Improve JavaDoc
|
Seemd like somehow I missed this test 🤔 |
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
===========================================
+ Coverage 42.23% 43.44% +1.2%
- Complexity 884 923 +39
===========================================
Files 214 220 +6
Lines 4217 4399 +182
Branches 434 436 +2
===========================================
+ Hits 1781 1911 +130
- Misses 2329 2374 +45
- Partials 107 114 +7 |
