Really allow zero interval + fix integer comparisons #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
============================================
- Coverage 41.55% 41.53% -0.02%
Complexity 911 911
============================================
Files 220 220
Lines 4353 4355 +2
Branches 435 437 +2
============================================
Hits 1809 1809
- Misses 2436 2438 +2
Partials 108 108 |
TVolden
approved these changes
May 20, 2020
|
Thanks @marcinar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that #105 wasn't fully fixed in #107. I also noticed that the equals method is broken since it tries to compare objects using
==(that works only for values -128...127).