Add support for HTTP Basic Authentication #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for HTTP Basic Authentication to the OCPP-J client, via two additional JSONConfiguration parameters for username and password. When both are set, the HTTP Basic Authentication header will be added to the websocket connect request. Note that HTTP Basic Authentication transmits username and password without encryption, so for secure communication, it must be used within a trusted channel, e.g. a secure websocket connection (WSS) or maybe an encrypted VPN connection. This change has originally been prepared by our former colleague: rtzll@8652108 and has successfully been tested in a plugfest.
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
============================================
- Coverage 41.53% 41.47% -0.07%
Complexity 911 911
============================================
Files 220 220
Lines 4355 4362 +7
Branches 437 438 +1
============================================
Hits 1809 1809
- Misses 2438 2445 +7
Partials 108 108 |
|
Hi @robert-s-ubi, Wow thanks for solving this one. The code looks fine. I just want to se the IT test pass (probably my own fault they fail), then I'll merge it. |
|
Done. Thanks again. It really means allot to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for HTTP Basic Authentication to the OCPP-J
client, via two additional JSONConfiguration parameters for username and
password. When both are set, the HTTP Basic Authentication header will
be added to the websocket connect request.
Note that HTTP Basic Authentication transmits username and password
without encryption, so for secure communication, it must be used within
a trusted channel, e.g. a secure websocket connection (WSS) or maybe an
encrypted VPN connection.
This change has originally been prepared by our former colleague:
rtzll@8652108
and has successfully been tested in a plugfest.