Enable ws connection timeout #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new configuration parameter CONNECT_TIMEOUT_IN_MS to specify the websocket connection timeout in milliseconds and use it when creating `WebSocketClient`. The default value is `0`, which means _no timeout_.
srehlig
force-pushed
the
feature/connection_timeout
branch
from
cf0f1dc
to
6a7cd1d
Compare
|
Who can review this PR? Would be great to have it in the next release. |
TVolden
approved these changes
Nov 4, 2021
|
Hi @srehlig, Thank you for the contribution, I have merged the changes. Sincerely, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new configuration parameter CONNECTION_TIMEOUT_IN_MS to specify the websocket connection timeout in milliseconds and use it when creating
WebSocketClient. The default value is0, which means no timeout.Fixes #158