Made Gson static to avoid creating it for each (de)serialization requ… #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TVolden
approved these changes
Feb 26, 2022
Comment on lines
+98
to
+102
| static { | ||
| GsonBuilder builder = new GsonBuilder(); | ||
| builder.registerTypeAdapter(ZonedDateTime.class, new ZonedDateTimeSerializer()); | ||
| gson = builder.create(); | ||
| } |
There was a problem hiding this comment.
Never seen this before, I had to look it up. It's called static block and it runs while the class loader runs, before main is called. Interesting.
|
Thanks for your contribution and sorry for my slow response time. It's now merged and the maven check was green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…est #168