Add ConfirmationCompletedHandler

[emilm]

Add a handler on each Confirmation perform actions after a confirmations are sent back to the Charge Point.
This is to send configuration variables etc after the BootNotification is confirmed from the server. Some CPs don't accept configs before the confirmation on BootNotification is returned.
This makes it possible within the synchronous nature of the handlers.

[mmauksch]

Quick Question: Is this feature only needed for BootNotifications? In that case maybe it's better to just have BootNotificationConfirmation implement the ConfirmationCompletedHandler and check in the Communicator: Is it assignable to ConfirmationCompletedHandler? If so: call it.

I'm coming from the point of view, that i'm not really comfortable with the idea of changing all the interfaces there to abstract classes and tacking on the whole handler thing onto confirmations that have no need for it.

I hope my point of view is described in a understandable way :)

[emilm]

I understand your point and I was uncomfortable with it myself. But it's a generic library and I am not sure which confirmation should have this handler or not.
In my case it's only the bootnotification, so I could have a specific implementation there.

Should the communicator type check and check for an interface? Would need additional logic.

[krzysztofxkwiecien]

Great timing as I was just about to start implementing similar functionality myself - I need it not only for BootNotification, but also for SignCertificate request from the security extension, so having it in the parent class is the best solution.

[TVolden]

The code looks good. The only concern I have with changing an interface to an abstract class is the limit of one class inheritance, but since they're internal models it should be okay.
You should still put your own name on the new class, and consider appending your name to the modified classes :)

[TVolden]

Should be replaced with your own name. :)

[emilm]

thanks ! I will add my name to it !

[emilm]

I updated it now! Hopefully it's fine :)

[TVolden]

As far as I can see this change won't affect the external API. Community, please confirm.

[TVolden]

Okay, it's merged.

Thanks for you for the contribution, it really means a lot.

Sincerely,
Thomas Volden