Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocpp-v1_6: BootNotificationRequest: Allow optional properties to be set null #223

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

bantu
Copy link
Contributor

@bantu bantu commented Nov 24, 2022

Fix #221

Copy link
Member

@TVolden TVolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The copy right year should be bumped up to 2022

@bantu
Copy link
Contributor Author

bantu commented Nov 24, 2022

@TVolden Updated

@TVolden
Copy link
Member

TVolden commented Nov 25, 2022

It's weird. The maven build failed because of some java doc.

@TVolden
Copy link
Member

TVolden commented Nov 25, 2022

Maybe try adding the target source to the pom.xml file:
https://stackoverflow.com/questions/58836862/jdk-11-and-javadoc

--- a/ocpp-v1_6/pom.xml
+++ b/ocpp-v1_6/pom.xml
@@ -116,6 +116,9 @@
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-javadoc-plugin</artifactId>
+              <configuration>
+                <source>8</source>
+              </configuration>
               <version>2.9.1</version>
               <executions>
                 <execution>

@bantu
Copy link
Contributor Author

bantu commented Nov 25, 2022

@TVolden Added

@bantu
Copy link
Contributor Author

bantu commented Nov 26, 2022

Are we seeing this here? https://stackoverflow.com/a/74185633

@bantu
Copy link
Contributor Author

bantu commented Nov 26, 2022

Are we seeing this here? https://stackoverflow.com/a/74185633

Possible. The version seems to match.

 Java configuration:
  Distribution: temurin
  Version: 11.0.17+8
  Path: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.17-8/x64

@TVolden
Copy link
Member

TVolden commented Nov 27, 2022

It seems so.

Command line was: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.17-8/x64/bin/javadoc @options @packages

So how to fix it?

@bantu
Copy link
Contributor Author

bantu commented Nov 27, 2022

I've removed my not-working fix commit from this branch.

So how to fix it?

Can we downgrade to Temurin 11.0.16 or upgrade to a fixed version?

@bantu
Copy link
Contributor Author

bantu commented Nov 27, 2022

Is the javadoc output actually deployed or used somewhere?

@bantu
Copy link
Contributor Author

bantu commented Nov 28, 2022

Can we downgrade to Temurin 11.0.16 or upgrade to a fixed version?

Added commit doing that.

@TVolden
Copy link
Member

TVolden commented Nov 28, 2022

It worked, amazing work @bantu.

@TVolden TVolden merged commit 84a4fcf into ChargeTimeEU:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BootNotificationRequest::setChargeBoxSerialNumber(null) throws NullPointerException
3 participants