Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a namespace fix to get 1.6 soap request through #30

Merged
merged 3 commits into from
Feb 20, 2018

Conversation

lahnaoja
Copy link
Contributor

Small changes to get an Ocpp1.6 soap request through, main fix is done to get the namespace interpreted:

  • Using getTextContent() in SOAPSyncHelper to get the "From" Address soap header as well
  • Xml schema annotation (package-info) fixed to include namespace prefix "ns"
  • WebServiceListener fixed to add "toUrl" in SessionInformation. This holds soap server address of the pole
  • Ignored Idea editor files that aren't needed in vcs for a maven project

Copy link
Member

@TVolden TVolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but a unit test is failing.

@TVolden TVolden assigned TVolden and lahnaoja and unassigned TVolden Feb 16, 2018
@TVolden
Copy link
Member

TVolden commented Feb 16, 2018

There is a null pointer exception in one of the unit tests, here is the output from the CI log:

unpackPayload_bootNotificationCallResultPayload_returnBootNotificationConfirmation(eu.chargetime.ocpp.test.SOAPCommunicatorTest)  Time elapsed: 0.364 sec  <<< ERROR!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.988% when pulling ab5aa33 on lahnaoja:develop into 26bdd8e on ChargeTimeEU:master.

@TVolden TVolden merged commit 4363bd8 into ChargeTimeEU:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants