-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DiagnosticsStatusNotification support. #38
Conversation
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
============================================
- Coverage 54.82% 54.65% -0.17%
- Complexity 651 660 +9
============================================
Files 151 155 +4
Lines 2302 2340 +38
Branches 152 155 +3
============================================
+ Hits 1262 1279 +17
- Misses 984 1004 +20
- Partials 56 57 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. It's clean and easy to read. I'll check it against the specifications before I approve.
* | ||
* MIT License | ||
* | ||
* Copyright (C) 2016 Thomas Volden <tv@chargetime.eu> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should change this to your own name and email.
* | ||
* MIT License | ||
* | ||
* Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be your name and email.
|
||
/* | ||
ChargeTime.eu - Java-OCA-OCPP | ||
Copyright (C) 2015-2016 Thomas Volden <tv@chargetime.eu> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate copyright.
|
||
MIT License | ||
|
||
Copyright (C) 2016-2018 Thomas Volden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be your name and email.
* | ||
* MIT License | ||
* | ||
* Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be your name and email.
|
||
MIT License | ||
|
||
Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be your name and email.
|
||
@Override | ||
public int hashCode() { | ||
return 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? :D It just has to be different between other confirmations.
|
||
MIT License | ||
|
||
Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be your name and email.
|
||
MIT License | ||
|
||
Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be your name and email.
8645cbc
to
9a7b077
Compare
No description provided.