Add FirmwareStatusNotification support. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
============================================
- Coverage 54.65% 54.47% -0.19%
- Complexity 660 667 +7
============================================
Files 155 159 +4
Lines 2340 2381 +41
Branches 155 158 +3
============================================
+ Hits 1279 1297 +18
- Misses 1004 1026 +22
- Partials 57 58 +1 |
TVolden
approved these changes
Apr 17, 2018
| /** | ||
| * This contains the status. | ||
| * | ||
| * @return connector. |
There was a problem hiding this comment.
Should change the docs to match the actual return type.
| } | ||
|
|
||
| /** | ||
| * This contains the status. |
There was a problem hiding this comment.
I would write: "This contains the progress status of the firmware installation."
- well actually, I steal these texts from the spec (shh)
| } | ||
|
|
||
| /** | ||
| * Required. This contains the identifier of the status. |
There was a problem hiding this comment.
I would write: "Required. This contains the progress status of the firmware installation."
(same as the spec)
| /** | ||
| * Required. This contains the identifier of the status. | ||
| * | ||
| * @param status FirmwareStatus, value != 0. |
There was a problem hiding this comment.
Can't really set a enum to 0? Applies to the next line too, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.