Add update firmware #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some tests for DiagnosticsStatusNotification and FirmwareStatusNotification.
|
Houston we have merge conflicts :( @sumlin can you take look? |
TVolden
reviewed
Apr 17, 2018
|
|
||
| MIT License | ||
|
|
||
| Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu> |
There was a problem hiding this comment.
Should be your name and e-mail. :)
There was a problem hiding this comment.
Yeah, added mine too
| // When | ||
| Feature[] features = profile.getFeatureList(); | ||
|
|
||
| // Then | ||
| assertThat(findFeature(features, "GetDiagnostics"), is(instanceOf(GetDiagnosticsFeature.class))); | ||
| assertThat(findFeature(features, "GetDiagnostics"), Is.is(instanceOf(GetDiagnosticsFeature.class))); |
There was a problem hiding this comment.
Principle, only one assert per unit test. Why?
It makes the naming the unit test allot easier for starters... And since an assert is a throwable, you don't know it's only the first failing assert or all the asserts that fail.
http://osherove.com/blog/2005/4/14/try-to-avoid-multiple-asserts-in-a-single-unit-test.html
There was a problem hiding this comment.
You're right, I'll fix that.
|
Implemented with #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.