0.5 cleanup spec added to json tests #55

eupakhomov · 2018-04-17T22:20:22Z

No description provided.

- backward compatibility of exposed API preserved - symmetric implementation for server and client - fail-fast for server/client builders for WSS not initialized with SSLContext/SSLSocketFactory - More explanatory exception for scheme and configuration mismatch for client than just NPE

WssFactoryBuilder and WssSocketBuilder now expose only the minimum required API

# Conflicts: # ocpp-v1_6/src/main/java/eu/chargetime/ocpp/WebSocketTransmitter.java # ocpp-v1_6/src/main/java/eu/chargetime/ocpp/wss/BaseWssSocketBuilder.java

coveralls · 2018-04-17T22:34:20Z

Coverage decreased (-0.5%) to 53.839% when pulling 6790105 on eupakhomov:0.5_cleanup_spec_added_to_json_tests into 905759c on ChargeTimeEU:master.

TVolden · 2018-04-18T12:29:19Z

The CI terminates in a new and weird way for this PR:

[...]
12:13:35.405 [main] DEBUG eu.chargetime.ocpp.JSONClient - Feature repository: FeatureRepository{featureList.size=21}
12:13:35.413 [WebSocketWorker-226] DEBUG eu.chargetime.ocpp.WebSocketListener - On connection open (resource descriptor: /testdummy)
12:13:35.413 [WebSocketWorker-226] DEBUG eu.chargetime.ocpp.Server - Session created: 869b6904-0f3a-4172-b438-600dcc9d3498
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

eupakhomov · 2018-04-18T13:55:35Z

Seems build hangs for some reason although nothing was added but cleanup (server side stop). I will think how to reproduce locally.

WebSocketListener: logging bug fixed Fake system expose isClosed flag directly from server to check server state, when stopped isStarted flag reset, method added to clear riggedToFail flag Tests are refactored: setup(Spec) and cleanup(Spec) moved to the parent class, system (server side) do startup/shutdown cycles for each feature and there is delay to ensure startup/shutdown, riggedToFail flag is cleared as a part of cleanup

codecov-io · 2018-04-18T17:14:00Z

Codecov Report

Merging #55 into master will decrease coverage by 0.45%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage      51.5%   51.04%   -0.46%     
  Complexity      759      759              
============================================
  Files           179      180       +1     
  Lines          3021     3048      +27     
  Branches        219      218       -1     
============================================
  Hits           1556     1556              
- Misses         1380     1407      +27     
  Partials         85       85

…added_to_json_tests

… be enough for tests - later on the value might be changed to appropriate)

…ctions

Logging added to fake central system for both starting and stopping WebSocketTransmitter and WebSocketListener updated to avoid NPE at stopping process Closing of Web Socket removed from WebSocketListener as WebSocketServer is taking care of it

TVolden · 2018-04-18T18:29:22Z

I'm sure you have seen, but the IC says 14 failures and 6 errors now:

[ERROR] Tests run: 43, Failures: 14, Errors: 6, Skipped: 0

Also let's check for TIME_WAIT connections

…atures to set JSON server/client network configuration setPingInterval method removed as duplication of configuration parameter (can we do it as it was added just recently?) JSON server/client constructors updated to accept configuration For fakse central system configuration with reuse_addr flag added to prevent failures on travis ci Time delay before starting central system removed from base spec (let's check if reuse_addr suffice)

eupakhomov · 2018-04-19T00:23:01Z

@TVolden finally travis have done proper thing. Although I am not completely satisfied how it's done (still with some pauses via Thread.sleep before client connections) but still I think overall improved. I had to force implementation of the network configuration for JSON as it was needed to set reuse_addr due to specific of container where Travis CI runs (hanging connections in TIME_WAIT state). I've merged ping interval in configuration as well and removed from API. Do you think it's ok as it's minor thing and was merged very recently?

sumlin · 2018-04-19T05:40:10Z

ocpp-v1_6/src/main/java/eu/chargetime/ocpp/WebSocketListener.java

@@ -132,6 +132,9 @@ public void onStart() {
        }

        server.setConnectionLostTimeout(pingInterval);
+
+        server.setReuseAddr(true);


That's what might solve all 'not connected' errors.

@sumlin for WebSocket default value of reuseAddr is false. Also according to the Socket specification initially this flag is not set. According to what I witnessed on two Windows and one Ubuntu machines tests are running fine without the flag set and only in Travis CI container we do have issues. Therefore I think not to set it by default but rather provide to end users more control over it by exposing json network configuration through API as discussed before.

@eupakhomov well, sometimes if you stops your bind-address operation, Linux core doesn't release a port, it is not according WS, that's core network stuff. I have no idea why 'false' state is a default state, so I vote to set is as 'true' by default, I do this all my life without any problems. @TVolden what do you think?

eupakhomov · 2018-04-19T09:10:55Z

@sumlin do you have also client-side related experience? If mentioned above is truth for Android -based devices as well? чт, 19 Апр 2018 г., 10:56 sumlin <notifications@github.com>:

…

***@***.**** commented on this pull request. ------------------------------ In ocpp-v1_6/src/main/java/eu/chargetime/ocpp/WebSocketListener.java <#55 (comment)> : > @@ -132,6 +132,9 @@ public void onStart() { } server.setConnectionLostTimeout(pingInterval); + + server.setReuseAddr(true); @eupakhomov <https://github.com/eupakhomov> well, sometimes if you stops your bind-address operation, Linux core doesn't release a port, it is not according WS, that's core network stuff. I have no idea why 'false' state is a default state, so I vote to set is as 'true' by default, I do this all my life without any problems. @TVolden <https://github.com/TVolden> what do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOpUGGfrcGSpRU73Tmg6XUwbd6KCaOE-ks5tqFFFgaJpZM4TZIx2> .

sumlin · 2018-04-19T09:24:05Z

@eupakhomov a few projects. Unfortunately, I have no powerful experience with Android. You may read this manual http://man7.org/linux/man-pages/man7/socket.7.html SO_REUSEPORT part. Or this https://superuser.com/a/127865 . It seems if you kill your application and it doesn't close all sockets correctly, a new instance of your application may catch the packets that have been sent to the old application. But it is not important for us I guess. I believe @TVolden should decide do we use SO_REUSEPORT or not.

eupakhomov · 2018-04-21T21:16:57Z

@TVolden @sumlin so reuseAddr by default set to true for the server.

TVolden · 2018-04-21T21:59:25Z

Yeah let's just have it set to true by default, that sounds good. Can't wait to stabilize the intrgration tests, they kinda loose their value when they fail all the time.

I'll review it tomorrow. Thanks for all your hard work, I really appreciate it.

TVolden · 2018-04-22T11:32:30Z

Looks like a small merge conflict with the imports

Conflicts resolved Base test classes moved to the separate package New tests derived from base tests classes

Eugene Pakhomov and others added 7 commits April 17, 2018 10:54

Javadoc added for WSS related methods and classes

1fd0d3d

WssFactoryBuilder and WssSocketBuilder now expose only the minimum required API

@overide annotations fixed

e1f0a48

Merge branch '0.5_cleanup'

dbd7ad7

# Conflicts: # ocpp-v1_6/src/main/java/eu/chargetime/ocpp/WebSocketTransmitter.java # ocpp-v1_6/src/main/java/eu/chargetime/ocpp/wss/BaseWssSocketBuilder.java

Merge remote-tracking branch 'upstream/master'

bc8437c

Merge branch '0.5_test_coverage_for_utilities'

ef0dcf1

Cleanup spec added to JSON tests

26fe7b2

TVolden approved these changes Apr 18, 2018

View reviewed changes

Eugene Pakhomov added 6 commits April 18, 2018 19:15

Merge remote-tracking branch 'upstream/master' into 0.5_cleanup_spec_…

971bff7

…added_to_json_tests

Timeout for server shutdown increased (so far just to test if it will…

74d16e5

… be enough for tests - later on the value might be changed to appropriate)

Base test class made abstract

70a392a

Port for test server changed to check travis server for hanging conne…

5edd89e

…ctions

Ports are reverted back

d711dba

eupakhomov added 7 commits April 19, 2018 00:28

To debug if server socket doesn't close at all or it's just slow

05d3d38

Same but waiting before starting test

5e78a9e

Thread pause placed correctly for debugging purposes

bd3e619

Also let's check for TIME_WAIT connections

Pause before connecting from client side

5f36176

Try to revert usage of TIME_WAIT connections

ea4e527

sumlin approved these changes Apr 19, 2018

View reviewed changes

eupakhomov added 2 commits April 21, 2018 22:40

SOAP integration tests are refactored

bd1a018

reuseAddr flag set by default to true for the server

4ece94f

TVolden approved these changes Apr 22, 2018

View reviewed changes

Master merged

6790105

Conflicts resolved Base test classes moved to the separate package New tests derived from base tests classes

TVolden merged commit ad7c414 into ChargeTimeEU:master Apr 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0.5 cleanup spec added to json tests #55

0.5 cleanup spec added to json tests #55

eupakhomov commented Apr 17, 2018

coveralls commented Apr 17, 2018 •

edited

Loading

TVolden commented Apr 18, 2018

eupakhomov commented Apr 18, 2018

codecov-io commented Apr 18, 2018 •

edited

Loading

TVolden commented Apr 18, 2018 •

edited

Loading

eupakhomov commented Apr 19, 2018 •

edited

Loading

sumlin Apr 19, 2018

eupakhomov Apr 19, 2018

sumlin Apr 19, 2018

eupakhomov commented Apr 19, 2018 via email

sumlin commented Apr 19, 2018 •

edited

Loading

eupakhomov commented Apr 21, 2018

TVolden commented Apr 21, 2018

TVolden commented Apr 22, 2018

0.5 cleanup spec added to json tests #55

0.5 cleanup spec added to json tests #55

Conversation

eupakhomov commented Apr 17, 2018

coveralls commented Apr 17, 2018 • edited Loading

TVolden commented Apr 18, 2018

eupakhomov commented Apr 18, 2018

codecov-io commented Apr 18, 2018 • edited Loading

Codecov Report

TVolden commented Apr 18, 2018 • edited Loading

eupakhomov commented Apr 19, 2018 • edited Loading

sumlin Apr 19, 2018

Choose a reason for hiding this comment

eupakhomov Apr 19, 2018

Choose a reason for hiding this comment

sumlin Apr 19, 2018

Choose a reason for hiding this comment

eupakhomov commented Apr 19, 2018 via email

sumlin commented Apr 19, 2018 • edited Loading

eupakhomov commented Apr 21, 2018

TVolden commented Apr 21, 2018

TVolden commented Apr 22, 2018

coveralls commented Apr 17, 2018 •

edited

Loading

codecov-io commented Apr 18, 2018 •

edited

Loading

TVolden commented Apr 18, 2018 •

edited

Loading

eupakhomov commented Apr 19, 2018 •

edited

Loading

sumlin commented Apr 19, 2018 •

edited

Loading