Fixes for compatibility and cleanup issues #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 27, 2018 13:16
…clients Minor clenup issues fixed in WebSocketListener
…(locally test runs ok) Some logging added and timeouts increased (to be slightly greater than server shutdown timeout) to debug the issue
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
============================================
- Coverage 53.49% 53.39% -0.11%
Complexity 812 812
============================================
Files 180 180
Lines 3047 3053 +6
Branches 211 212 +1
============================================
Hits 1630 1630
- Misses 1332 1338 +6
Partials 85 85 |
TVolden
approved these changes
Jun 28, 2018
|
Hi Evgeny, I think it's a good decision to accept clients that doesn't have the special protocol header (can't remember what it's called). Thomas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSONServer fixed to be backward compatible with previous versions of clients
Minor cleanup issues fixed in WebSocketListener